Drop special support for tracing Cython functions #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
drop_cython_profiling_support
branch
from
431045a
to
8a48fc4
Compare
Up until now, if the program being profiled included a Cython module built with profiling support enabled, those Cython functions would show up in our Python call stacks. This was rarely useful in practice, as most Cython libraries aren't distributed with profiling support enabled. Supporting this had significant maintenance costs that outweigh the benefits, so we are dropping that special support for Cython. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
We set `PYTHONMALLOC=malloc` when doing our Valgrind pass so that Valgrind has transparency into allocations being made by the process that it's tracking, but we don't need or want that to apply to subprocesses spawned by the tracked process that Valgrind doesn't need to know about. Because `PYTHONMALLOC=malloc` can actually change the behavior of these tests depending on difficult to control factors, unset it. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
drop_cython_profiling_support
branch
from
8a48fc4
to
46854a2
Compare
|
This isn't really a good way of filtering out the artificial Cython frames, but I haven't found a good way. I'd be very happy to switch to a cheaper method, if there is one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, if the program being profiled included a Cython module built with profiling support enabled, those Cython functions would show up in our Python call stacks. This was rarely useful in practice, as most Cython libraries aren't distributed with profiling support enabled. Supporting this had significant maintenance costs that outweigh the benefits, so we are dropping that special support for Cython.
Signed-off-by: Matt Wozniski mwozniski@bloomberg.net