Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider macOS to be fully supported #250

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Consider macOS to be fully supported #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/supported_environments.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Supported operating systems

You will have the best Memray experience on Linux.

We have experimental support for macOS 11 or newer. We cannot support older
We also support macOS 11 or newer. We cannot support older
macOS versions, as they don't provide a C++17 compatible runtime. Although all
features work on macOS, the way that macOS applications and Python libraries
are typically distributed often results in subpar native stacks on Mac. See
Expand Down
1 change: 1 addition & 0 deletions news/194.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Memray is now fully supported on macOS, and the warnings that macOS support is experimental have been dropped.
8 changes: 0 additions & 8 deletions src/memray/_memray.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,14 +367,6 @@ cdef class Tracker:
else:
raise TypeError("destination must be a SocketDestination or FileDestination")

def __init__(self, object file_name=None, *, object destination=None,
bool native_traces=False, unsigned int memory_interval_ms = 10,
bool follow_fork=False, bool trace_python_allocators=False):
if sys.platform == "darwin":
pprint(":warning: [bold red] Memray support in MacOS is still experimental [/]:warning:", file=sys.stderr)
pprint("[yellow]Please report any issues at https://github.com/bloomberg/memray/issues[/]", file=sys.stderr)
pprint("", file=sys.stderr)

def __cinit__(self, object file_name=None, *, object destination=None,
bool native_traces=False, unsigned int memory_interval_ms = 10,
bool follow_fork=False, bool trace_python_allocators=False):
Expand Down