Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a landing page for the documentation #279

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

pablogsal
Copy link
Member

To make thinks shinny and cool, add a landing page instead of using the
Sphinx index page.

@pablogsal
Copy link
Member Author

Example rendering: https://pablogsal.github.io/memray

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged your fixups, and added some improvements of my own as a new fixup. Also:

docs/_templates/index.html Outdated Show resolved Hide resolved
docs/_templates/index.html Show resolved Hide resolved
To make thinks shinny and cool, add a landing page instead of using the
Sphinx index page.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the HTML/CSS here -- LGTM! :)

@pablogsal pablogsal merged commit 24200bc into bloomberg:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants