Update the type annotations for our IPython magic #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of IPython adds annotations for `Magics`, so we need to update to avoid warnings about unnecessary `type: ignore` comments. Additionally, I realized that our `parse_options` method is unintentionally overriding a method inherited from our base class. We could rename the method to avoid the collision, but since its body is only one line, let's just inline it into the caller. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
pablogsal
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of IPython adds annotations for
Magics, so we need to update to avoid warnings about unnecessarytype: ignorecomments.Additionally, I realized that our
parse_optionsmethod is unintentionally overriding a method inherited from our base class. We could rename the method to avoid the collision, but since its body is only one line, let's just inline it into the caller.