Ensure the tests can be ran independently with Python 3.11 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
prime
branch
2 times, most recently
from
d5ffaf3
to
9992f50
Compare
|
I also tested that after this PR we can run every test individually in isolation by running: |
As Python 3.11 allocates memory when a function is first traced, some of our tests results are depending on the fact that the allocators don't trigger when a function is traced for the first time (what happens is that other tests warm the pymalloc allocator). To avoid this, add a new context manager that allows to run a piece of code under tracing to warmup the caches, including the calling function. For the calling function to be included the context manager needs to be implemented in C. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Python 3.11 allocates memory when a function is first traced, some of
our tests results are depending on the fact that the allocators don't
trigger when a function is traced for the first time (what happens is
that other tests warm the pymalloc allocator).
To avoid this, add a new context manager that allows to run a piece of
code under tracing to warmup the caches, including the calling function.
For the calling function to be included the context manager needs to be
implemented in C.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.