Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistently binary multiples in the reporters #299

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 18, 2023

We are inconsistently using decimal and binary multiples in different
places where we report sizes.

@pablogsal pablogsal changed the title Use powers of 10 when converting between byte multiples Use consistently binary multiples in the reporters Jan 18, 2023
We are inconsistently using decimal and binary multiples in different
places where we report sizes.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal enabled auto-merge (rebase) January 18, 2023 21:06
@pablogsal pablogsal merged commit 6497c76 into bloomberg:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants