Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the perf results for version v1.6.0 #300

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

pablogsal
Copy link
Member

Version 1.6.0 added a bunch of performance improvements and we should
reflect this on the documentation.

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

Version 1.6.0 added a bunch of performance improvements and we should
reflect this on the documentation.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
The Alpine Linux images have updated their linker flags to include some
new options between "-Wl" and "--strip-all". This causes our
substitution to fail. To ensure this doesn't happen again we can just
substitute "--strip-all" by "-g", which is ignored by the linker (notice
we cannot just substitute it by nothing because leaving just "-Wl" can
fail).

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 69a1639 into bloomberg:main Jan 18, 2023
@pablogsal pablogsal deleted the bench_new branch January 18, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants