Regenerate flame graphs with more symbols #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate the flame graphs found in the docs in an environment that has DWARF for libc and libsqlite, as well as source code available for libpython via a python3.11-dbg package. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
pablogsal
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was too quick to approve #301. When I looked more closely at the regenerated files, I noticed we had lost visibility into what some of the C libraries were doing, because the new flame graphs were generated in an environment without DWARF info for those libraries.
Re-regenerate these with more symbols.