-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new patch to libbacktrace to integrate with debuginfod #308
Conversation
pablogsal
commented
Jan 20, 2023
- Add a new patch to libbacktrace to integrate with debuginfod
- Update the vendored libbacktrace files with the latest patch
0a32a60
to
f940908
Compare
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Outdated
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Outdated
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Outdated
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Outdated
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Outdated
Show resolved
Hide resolved
src/vendor/libbacktrace_2446c66076480ce07a6bd868badcbceb3eeecc2e_debuginfod_patch.diff
Show resolved
Hide resolved
Oh, I probably shouldn't have made suggestions on the patch - I was thinking that was the source of truth and it'd be easier to apply them there and then regenerate the code, which is true, but of course you need to also fix up the line numbers in the patch because of the new/removed lines. Oops. |
29189fa
to
464f5b4
Compare
This patch adds integration with debuginfod, which is a HTTP/HTTPS server for distributing ELF/DWARF debug information. The integration allows libbacktrace to retrieve the necessary debug information from the debuginfod server, rather than relying on locally available debug files. With this integration, developers will be able to use memray reporters to more easily debug their applications and diagnose issues, even when the necessary debug information is not available locally. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
This commit regenerates the vendored libbacktrace files with the debuginfod integration patch. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing this locally I noticed patch
was complaining about trailing whitespace on a few of the lines in the patch. I've force pushed a fix for that.
Otherwise, LGTM!