Improve text readability in jupyterlab dark theme #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
approved these changes
Apr 21, 2023
This applies to: - progress bar text status - jupyter magic %%memray_flamegraph output filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to:
Issue number of the reported bug or feature request: #343
Describe your changes
I changed the color blue to cyan for a few text outputs to improve readability in dark themes.
Testing performed
The screenshot above shows good readability of the cyan text in both light and dark themes, and uses a color number below 16, so it displays properly in terminals with 16 colors.
Additional context
Closes: #343