New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit setup #356
Merged
Merged
Add pre-commit setup #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefmolin
force-pushed
the
add-pre-commit
branch
from
April 24, 2023 15:34
e07c84a
to
53ff04b
Compare
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
This check is to naive for our needs. It doesn't see our Sphinx configuration, and is unaware of Intersphinx, so it doesn't realize that something single quoted can be a reference to an object with the default Sphinx role configured in `docs/conf.py`. Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
godlygeek
force-pushed
the
add-pre-commit
branch
from
April 24, 2023 17:03
541499c
to
8f0c9f9
Compare
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
stefmolin
force-pushed
the
add-pre-commit
branch
from
April 24, 2023 17:06
8f0c9f9
to
86cb224
Compare
godlygeek
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: closes #355
Describe your changes
.pre-commit-config.yaml
fileTesting performed
pre-commit run --files *
Additional context
I also added some pre-commit hooks that I like to work. These are in the top two sections of the YAML file.