Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VIRTUAL_ENV variable for python binary #36

Merged
merged 1 commit into from Apr 22, 2022

Conversation

elfosardo
Copy link
Contributor

Use the VIRTUAL_ENV environment variable inside the Dockerfile to define the PYTHON variable
if VIRTUAL_ENV changes it will be automatically reflected in the PYTHON binary

@pablogsal
Copy link
Member

Thanks! Per our contribution licensing documentation, would you mind adding a Signed-Off-By: tag to your commit message to indicate that you have read and agree to our Developer's Certificate of Origin?

That should be as easy as doing:

$ git commit --amend -C HEAD -s
$ git push -f

from a checkout of this branch.

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@pablogsal
Copy link
Member

Thanks a lot @elfosardo for your contribution 🎉

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit a35321a into bloomberg:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants