Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tox dependancy #362

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove tox dependancy #362

merged 1 commit into from
Apr 24, 2023

Conversation

sjirwin
Copy link
Contributor

@sjirwin sjirwin commented Apr 24, 2023

Issue number of the reported bug or feature request: #350

Describe your changes
make is now used for orchestrating maintenance commands for the repository so tox is not needed anymore

Testing performed
verified new settings by running make dev-install and make pycoverage locally

Additional context
Closes #350

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the changes to the benchmarks/ directory (those files are vendored directly from an upstream source), and needed to switch the Ubuntu image to use ./venv instead of just /venv since we're not running as root in it.

Otherwise, LGTM!

@godlygeek godlygeek enabled auto-merge (rebase) April 24, 2023 18:48
auto-merge was automatically disabled April 24, 2023 20:17

Head branch was pushed to by a user without write access

make is now used for orchestrating maintenance commands for the repository
so tox is not needed anymore.

Signed-off-by: Scott Irwin <sirwin@rocketmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek enabled auto-merge (rebase) April 24, 2023 21:25
@godlygeek godlygeek merged commit 2815898 into bloomberg:main Apr 24, 2023
24 of 25 checks passed
@sjirwin sjirwin deleted the pycon_us branch April 25, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop tox dependency
2 participants