Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Only check for news entries if src/ changed #365

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented Apr 24, 2023

Describe your changes

  • Separate the check for a news entry into its own action to apply only to src/* files
  • Clean up sanity-check.yml workflow file

Testing performed
This PR will trigger the sanity-check.yml workflow file (which will now pass since there is no need for the skip news label), but not the news-check.yml workflow file since there are no changes to src/memray/*.

@godlygeek godlygeek changed the title Separate news check action and only run for changes to src/memray ci: Only check for news entries if src/ changed Apr 24, 2023
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit c435f9c into bloomberg:main Apr 24, 2023
26 checks passed
@stefmolin stefmolin deleted the news-check-action branch April 24, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants