-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline linting processes #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefmolin
force-pushed
the
streamline-lint
branch
2 times, most recently
from
April 24, 2023 23:26
a45b0f3
to
28e9244
Compare
godlygeek
reviewed
Apr 24, 2023
stefmolin
force-pushed
the
streamline-lint
branch
from
April 25, 2023 00:04
6ff5660
to
2429bbf
Compare
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
godlygeek
force-pushed
the
streamline-lint
branch
from
April 25, 2023 00:06
5f17d9f
to
7c7015e
Compare
godlygeek
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: closes #360
Describe your changes
check-manifest
andclang-format
to pre-commit setup (removing frommake
)make
commandsMakefile
and C files found during lintingTesting performed
Reinstalled the hooks to allow for pre-commit and pre-push hooks. Running
pre-commit run --all-files
runs in the pre-commit stage so all butcheck-manifest
. Runningpre-commit run --all-files --hook-stage pre-push
only runscheck-manifest
.