Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline linting processes #370

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Conversation

stefmolin
Copy link
Contributor

Issue number of the reported bug or feature request: closes #360

Describe your changes

  • Add check-manifest and clang-format to pre-commit setup (removing from make)
  • Remove intermediary make commands
  • Clean up Makefile and C files found during linting
  • Configure pre-push hook to run in CI
  • Remove extra requirements absorbed into pre-commit

Testing performed
Reinstalled the hooks to allow for pre-commit and pre-push hooks. Running pre-commit run --all-files runs in the pre-commit stage so all but check-manifest. Running pre-commit run --all-files --hook-stage pre-push only runs check-manifest.

@stefmolin stefmolin force-pushed the streamline-lint branch 2 times, most recently from a45b0f3 to 28e9244 Compare April 24, 2023 23:26
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit a5e6315 into bloomberg:main Apr 25, 2023
27 checks passed
@stefmolin stefmolin deleted the streamline-lint branch April 25, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide what to do about linting
2 participants