Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sphinx-lint pre-commit hook #374

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Add sphinx-lint pre-commit hook #374

merged 1 commit into from
Apr 26, 2023

Conversation

stefmolin
Copy link
Contributor

closes #347

Describe your changes
Add sphinx-lint pre-commit hook.

Testing performed
Introduced some issues into .rst files, then ran pre-commit run --all-files.

@stefmolin
Add sphinx-lint pre-commit hook
208dfa5 
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
pablogsal
pablogsal approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot! ✨

@pablogsal pablogsal merged commit 16b2a50 into bloomberg:main Apr 26, 2023
26 checks passed
@stefmolin stefmolin deleted the sphinx-lint branch April 26, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run sphinx-lint in make lint
2 participants
@stefmolin @pablogsal