Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around an IPython packaging bug #380

Merged

Conversation

godlygeek
Copy link
Contributor

@godlygeek godlygeek commented Apr 28, 2023

This works around a packaging bug in IPython 8.13: it drops support for Python 3.8, but still declares support for 3.8 in its python_requires, so pip installs the new version even for Python versions that don't support it.

See ipython/ipython#14053

@godlygeek godlygeek self-assigned this Apr 28, 2023
@godlygeek godlygeek force-pushed the work_around_ipython_packaging_bug branch from a5382b1 to 9804110 Compare April 28, 2023 20:41
This works around a packaging bug in IPython 8.13: it drops support for
Python 3.8, but still declares support for 3.8 in its `python_requires`,
so `pip` installs the new version even for Python versions that don't
support it.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek godlygeek force-pushed the work_around_ipython_packaging_bug branch from 9804110 to 86d2576 Compare April 28, 2023 21:00
@godlygeek godlygeek changed the title Require an old IPython for old Python versions Work around an IPython packaging bug Apr 28, 2023
Copy link
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahmonod sarahmonod merged commit 62fb9ad into bloomberg:main May 1, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants