Pre-factoring in preparation for temporal high water mark reports #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets Cython generate very slightly more efficient code for `curr_record.intervals` by accessing the field from the struct directly, instead of doing a Python attribute lookup to access it. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Instead of `--temporal-leaks`, users will need to provide two arguments: `--temporal --leaks`. This is in preparation for allowing temporal high water mark reports in the future. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
temporal_hwm_prefactor
branch
from
533b9da
to
882eb7a
Compare
This improves readability, and lays the groundwork for allowing `HighWaterMarkAggregator` to track per-snapshot high water mark allocations by location. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
temporal_hwm_prefactor
branch
from
882eb7a
to
f0454a0
Compare
pablogsal
approved these changes
May 22, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split some code out of #326. These changes lay some of the groundwork for changes in #326, but can be reviewed separately and should be less controversial.