Allow to create non-minimized javascript files #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make debugging of the generated javascript possible, we need to allow to set `minimize: false` in the webpack.config.js file. Unfortunately this has some problems: * The non-minimized javascript templates includes some stuff that causes jinja2 to freak out because it tries to interpolate the contents. * The order of declaration of some classes is wrong and it fails to create some objects at import time. To help with this, add a new globally available function in the jinja templates that allows us to include files without interpolating them and fix the order-of-definition problems. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 85.41% 85.11% -0.31%
==========================================
Files 29 29
Lines 3621 3621
==========================================
- Hits 3093 3082 -11
- Misses 528 539 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make debugging of the generated javascript possible, we need to allow
to set
minimize: falsein the webpack.config.js file. Unfortunatelythis has some problems:
jinja2 to freak out because it tries to interpolate the contents.
create some objects at import time.
To help with this, add a new globally available function in the jinja
templates that allows us to include files without interpolating them and
fix the order-of-definition problems.