Fix cibuildwheel before-all configuration
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you provide multiple commands, `cibuildwheel` naively stitches them together into one shell command by concatenating them with `&&` in between. That changes the meaning of a shell `||` (it winds up running if a completely unrelated command fails). Fix this by switching from `||` to an `if` statement. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_cibw_before_all
branch
from
73dd2e3
to
5a18e46
Compare
pablogsal
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you provide multiple commands,
cibuildwheelnaively stitches them together into one shell command by concatenating them with&&in between. That changes the meaning of a shell||(it winds up running if a completely unrelated command fails).Fix this by switching from
||to anifstatement.