ci: Test with Python 3.12 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 29 29
Lines 3631 3631
=======================================
Hits 3091 3091
Misses 540 540
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Our test suite builds a test extension, which needs `distutils`, which is no longer part of the standard library as of Python 3.12 and needs to be provided by `setuptools` instead. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Python 3.12 is not yet ABI stable, so we should not publish wheels yet. Removing the 3.12 wheels right before publishing allows us to leave them in the GitHub artifact bundle, so we can manually download them from CI if we need them for something. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
ci_for_3.12
branch
2 times, most recently
from
c6a7486
to
c6fc6b2
Compare
|
OK, this should be ready to be reviewed. The way I'm avoiding publishing the 3.12 wheels is hacky, but I don't see a non-hacky solution, and I manually tested that it works by forcing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.