Support added for memray --version & -V #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Apurva Khatri <apurvakhatri2011@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 84.85% 85.04% +0.19%
==========================================
Files 29 29
Lines 3631 3631
==========================================
+ Hits 3081 3088 +7
+ Misses 550 543 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
reviewed
Jul 13, 2023
pablogsal
reviewed
Jul 13, 2023
|
Thanks a lot for the PR @apurvakhatri 🖤 |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #417 *
Describe your changes
In order for memray to display its own version, I have added an argument to basic parser. Since it is added as an option rather than positional argument, only the init file was modified. Further, README has been updated on how to use the option.
Testing performed
The command "memray --version" or "memray -V" successfully ran on my system (MacOS).
Additional context