Support old versions of greenlet #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest versions of greenlet now support 3.11, though 3.12 is not yet supported. Update our tests to exercise our greenlet handling on 3.11. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Prior to greenlet 1.0, the "greenlet" module wasn't a Python package containing a private extension module, it was just a public extension module. Handle this case by updating our hacky detection for greenlet being imported after tracking has begun to recognize "greenlet.*.so" in addition to "_greenlet.*.so", and update our trace hook injection to fall back to `greenlet.settrace` if `greenlet._greenlet` hasn't been imported but `greenlet` has. Note that we can't unconditionally call `greenlet.set_trace`, because at the point where our hooks are being installed, it's possible that the `greenlet._greenlet` extension module has been imported but the `greenlet/__init__.py` module doesn't yet have a `settrace` attribute because it hasn't yet done `from ._greenlet import settrace`. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
These don't show up as lint errors since the scripts are given as string literals, but when I copied these test programs out into standalone scripts to try to investigate the greenlet 0.X issue, Black and flake8 caught these issues. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
update_greenlet_support
branch
from
fff08ba
to
6d37b38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 91.72% 91.69% -0.03%
==========================================
Files 90 90
Lines 10503 10506 +3
Branches 1446 1446
==========================================
Hits 9634 9634
- Misses 866 869 +3
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Jul 29, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384