Fix a bug causing empty summary reports
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
==========================================
+ Coverage 91.64% 91.72% +0.07%
==========================================
Files 90 90
Lines 10523 10524 +1
Branches 1446 1446
==========================================
+ Hits 9644 9653 +9
+ Misses 876 868 -8
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
godlygeek
force-pushed
the
fix_summary_reporter
branch
from
8d6defd
to
9b59af0
Compare
Our TUI's `update_snapshot` method declares that it accepts any iterable, but it expects to be able to iterate over the snapshot repeatedly, which means that it does not accept generators or other iterators that can only be iterated once. Update its type annotation to require a sequence instead of an iterable, and update the caller that was providing a generator to instead provide a sequence. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
See changelog for more details. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_summary_reporter
branch
from
9b59af0
to
32f2be6
Compare
pablogsal
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our TUI's
update_snapshotmethod declares that it accepts any iterable, but it expects to be able to iterate over the snapshot repeatedly, which means that it does not accept generators or other iterators that can only be iterated once.Update its type annotation to require a sequence instead of an iterable, and update the caller that was providing a generator to instead provide a sequence.
Closes #434