Add --wheel to the make dist target
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we build the distribution without "--wheel", `build_ext` gets called during "python -m build" from the temporary build directory, while with "--wheel" the files built during "make build" are copied into the created wheel. This allows the build to be more reproducible as in this way the DWARF included in the extension to not change due to the temporary directory path being part of it.
lkollar
approved these changes
Apr 22, 2022
pradyunsg
reviewed
Apr 22, 2022
| @@ -42,7 +42,7 @@ build-js: $(generated_js_files) ## Build package assets in-place | |||
|
|
|||
| .PHONY: dist | |||
| dist: ## Generate Python distribution files | |||
| $(PYTHON) -m build . | |||
| $(PYTHON) -m build --wheel . | |||
There was a problem hiding this comment.
You likely need a --sdist as well, otherwise this will only generate a wheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #30
When we build the distribution without "--wheel",
build_extgetscalled during "python -m build" from the temporary build directory,
while with "--wheel" the files built during "make build" are copied into
the created wheel. This allows the build to be more reproducible as in
this way the DWARF included in the extension to not change due to the
temporary directory path being part of it.