Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Allow producing a memray.1 man page #524

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

godlygeek
Copy link
Contributor

This man page will contain a small bit of prose explaining what Memray is and where to find the full documentation, followed by CLI usage information scraped from the --help of each of our subcommands. Distros can build the man page for any given version to include in distro packages of Memray.

@godlygeek godlygeek self-assigned this Jan 12, 2024
@godlygeek
Copy link
Contributor Author

https://gist.github.com/godlygeek/e3ab347806010596cab9784ccc33f1a8 shows the memray.1 that's generated by running make -C docs man from the repo root (assuming that a virtualenv has been activated and pip install -r requirements-docs.txt has been run to install the docs generation dependencies).

@alexmyczko Can you check if that man page meets your needs? It's more informative than what you propose in #523 and it shouldn't require too much more work to keep up to date.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d491065) 92.37% compared to head (c937da0) 92.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   92.37%   92.32%   -0.06%     
==========================================
  Files          91       91              
  Lines       11270    11270              
  Branches     1571     1571              
==========================================
- Hits        10411    10405       -6     
- Misses        854      860       +6     
  Partials        5        5              
Flag Coverage Δ
cpp 85.66% <ø> (-0.17%) ⬇️
python_and_cython 95.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahmonod
Copy link
Contributor

Should we exercise this in CI in some way? At least to ensure that the manual page can be generated and isn't empty for example.

@godlygeek
Copy link
Contributor Author

Should we exercise this in CI in some way?

Yes, let's.

At least to ensure that the manual page can be generated and isn't empty for example.

I'll make sure it's generated. I'm not gonna check for emptiness - we don't do that for the HTML output, so doing it for the man output seems superflous. But I will update make docs to build the man page, and CI already tests that make docs succeeds.

Let's not worry about the "empty output" case unless we ever find a case where Sphinx generates an empty file and returns a success rcode to us. 😃

This man page will contain a small bit of prose explaining what Memray
is and where to find the full documentation, followed by CLI usage
information scraped from the `--help` of each of our subcommands.
Distros can build the man page for any given version to include in
distro packages of Memray.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Copy link
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 578e02d into bloomberg:main Feb 23, 2024
17 checks passed
@godlygeek godlygeek mentioned this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants