Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how to handle container OOM #605

Merged
merged 1 commit into from
May 21, 2024

Conversation

micheleAlberto
Copy link
Contributor

Issue number of the reported bug or feature request: #598

Describe your changes
This adds some documentation about how to run memray in containers that get out of memory

Testing performed
I tested the scripted solution locally (but not in a container)

this is how the docs render image

@godlygeek
Copy link
Contributor

@micheleAlberto Would you mind updating your commit to include a Signed-off-by? See https://github.com/bloomberg/memray/blob/main/CONTRIBUTING.md#contribution-licensing - you should just be able to do a git commit --amend -s -C HEAD and then a git push --force-with-lease to add that.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.74%. Comparing base (41248ed) to head (96228d5).
Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   92.55%   92.74%   +0.19%     
==========================================
  Files          91       92       +1     
  Lines       11304    11234      -70     
  Branches     1581     2055     +474     
==========================================
- Hits        10462    10419      -43     
+ Misses        837      815      -22     
+ Partials        5        0       -5     
Flag Coverage Δ
cpp 92.74% <ø> (+6.80%) ⬆️
python_and_cython 92.74% <ø> (-2.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michele Alberto <robbyetor@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some rewording and fleshed some ideas out, but kept your general structure. Thanks so much for the contribution!

@godlygeek godlygeek merged commit 9f3c23f into bloomberg:main May 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants