Fix a segfault on macOS when _dyld_shared_cache_contains_path is not available #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
checking
branch
3 times, most recently
from
ab34848
to
33d589a
Compare
godlygeek
reviewed
May 29, 2024
godlygeek
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 92.55% 92.97% +0.42%
==========================================
Files 91 92 +1
Lines 11304 11323 +19
Branches 1581 2076 +495
==========================================
+ Hits 10462 10528 +66
+ Misses 837 795 -42
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
force-pushed
the
checking
branch
2 times, most recently
from
ef9abc1
to
7337dae
Compare
The _dyld_shared_cache_contains_path is only available in macOS 11.0 or later. As we are compiling in a new system that's newer than 11.0 but setting the deployment target to an older version, it's possible that the _dyld_shared_cache_contains_path is not available in the target platform and in that case we will segfault when calling it. It's also possible that when compiling memray in an old system _dyld_shared_cache_contains_path is not even prototyped in the headers. To handle this, we change to fetch the function via a dlopen/dlsym approach that will be generic in all macOS versions at the cost of an extra call to dlopen the first time we interpose symbols. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _dyld_shared_cache_contains_path is only available in macOS 11.0
or later. As we are compiling in a new system that's newer than 11.0 but
setting the deployment target to an older version, it's possible that
the _dyld_shared_cache_contains_path is not available in the target
platform and in that case we will segfault when calling it. It's also
possible that when compiling memray in an old system
_dyld_shared_cache_contains_path is not even prototyped in the headers.
To handle this, we change to fetch the function via a dlopen/dlsym approach
that will be generic in all macOS versions at the cost of an extra call
to dlopen the first time we interpose symbols.