Fix reporting of "Own Memory" in TUI reporters #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `live` and `summary` reporters include a column for the number of bytes directly allocated by a particular function (called "Own Bytes" or "Own Memory", with a corresponding column for the percentage of memory directly allocated by that function). A bug in our summation led to us undercounting and misreporting these columns. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
fix_tui_own_memory_reporting
branch
from
e77f410
to
ea1e5f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 92.55% 92.79% +0.24%
==========================================
Files 91 92 +1
Lines 11304 11236 -68
Branches 1581 2058 +477
==========================================
- Hits 10462 10427 -35
+ Misses 837 809 -28
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
liveandsummaryreporters include a column for the number of bytes directly allocated by a particular function (called "Own Bytes" or "Own Memory", with a corresponding column for the percentage of memory directly allocated by that function).A bug in our summation led to us undercounting and misreporting these columns.