Test with Python 3.13 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After-fork handlers installed by `pthread_atfork` run before the interpreter has reinitialized its locks. That poses a problem for us in Python 3.13, because the CPython API we call to install our profile function has been changed to acquire a lock that's not yet been reinitialized. Switch to using Python fork handlers installed by `os.register_at_fork` instead. These are called after the locks have been reinitialized. I've removed a comment saying that we must register the after-fork handlers only after all of our other one-time setup has been done. That can't possibly be correct: since it's not possible to unregister a handler, these handlers can fire after tracking has stopped, which means they must do nothing when tracking isn't active, and so installing them before tracking starts must be harmless. If this wasn't the case, we always would have had incorrect behavior in the case where tracking is restarted after having been stopped. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
- Use the new `PyEval_SetProfileAllThreads` public function, instead of our hacky backport of it. - Handle `_Py_IsFinalizing` being promoted to a public API. - Handle the prototype for `_PyMem_GetCurrentAllocatorName` being removed. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
test_with_python_3.13
branch
from
e0648a5
to
ae78675
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 92.55% 93.06% +0.51%
==========================================
Files 91 94 +3
Lines 11304 11408 +104
Branches 1581 2089 +508
==========================================
+ Hits 10462 10617 +155
+ Misses 837 791 -46
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Note that wheels are not yet published, because Python 3.13 is not yet ABI stable. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
godlygeek
force-pushed
the
test_with_python_3.13
branch
from
ae78675
to
90ea24c
Compare
pablogsal
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that wheels are not yet published, because Python 3.13 is not yet ABI stable.