Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-5378: Task browse perf. format date utc -> est #762

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

dchhabda
Copy link

converting date in string form from utc to est is resource intensive causing max time for processing task browse request; 95% of time spend on converting utc -> est bulk tasks(~25k) that will be thrown away as tasks are dynamic. Instead, only format date for max number of tasks that can be displayed to the user.

@dchhabda dchhabda requested a review from XiChenn August 16, 2022 19:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2870562802

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.655%

Totals Coverage Status
Change from base Build 2862759702: 0.002%
Covered Lines: 16185
Relevant Lines: 17099

💛 - Coveralls

Copy link

@XiChenn XiChenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you.

@dchhabda dchhabda merged commit 1629864 into main Aug 17, 2022
@XiChenn XiChenn deleted the tasklist-perf branch September 23, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants