Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-5531 Fixed missing comma in completed by sql #798

Merged
merged 1 commit into from
Dec 8, 2022
Merged

RDISCROWD-5531 Fixed missing comma in completed by sql #798

merged 1 commit into from
Dec 8, 2022

Conversation

kbecker42
Copy link

  • Fixed bug with priority being overwritten with user name while sorting on "completed by" column.

@kbecker42 kbecker42 added the bug label Dec 8, 2022
XiChenn
XiChenn approved these changes Dec 8, 2022
View reviewed changes
Copy link

@XiChenn XiChenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you.

@kbecker42 kbecker42 changed the title Missing comma in sql. RDISCROWD-5531 Fixed completed by column overwriting priority when sorting Dec 8, 2022
@kbecker42 kbecker42 changed the title RDISCROWD-5531 Fixed completed by column overwriting priority when sorting RDISCROWD-5531 Fixed missing comma in completed by sql Dec 8, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3651682988

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.96%
Totals Coverage Status
Change from base Build 3649402440: 0.0%
Covered Lines: 16411
Relevant Lines: 17466
💛 - Coveralls

@kbecker42 kbecker42 merged commit 1422fe8 into main Dec 8, 2022
@dchhabda dchhabda deleted the RDISCROWD-5531-2 branch December 27, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiChenn XiChenn XiChenn approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@kbecker42 @coveralls @XiChenn