Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDISCROWD-5627: Allow editing of taskruns #804

Merged
merged 3 commits into from
Jan 25, 2023
Merged

RDISCROWD-5627: Allow editing of taskruns #804

merged 3 commits into from
Jan 25, 2023

Conversation

dchhabda
Copy link

@dchhabda dchhabda commented Jan 23, 2023 •
edited
Loading

This PR will enable admin and users to edit their submissions. Enable admin for updating submissions such as __upload_url when moving files to bucket that has extended expiration upon task completion.

@coveralls
Copy link

coveralls commented Jan 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4006792771

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 93.974%
Totals Coverage Status
Change from base Build 3997983707: 0.004%
Covered Lines: 16467
Relevant Lines: 17523
💛 - Coveralls

@dchhabda dchhabda requested a review from XiChenn January 24, 2023 15:13
XiChenn
XiChenn reviewed Jan 24, 2023
View reviewed changes
pybossa/api/task.py Outdated Show resolved Hide resolved
pybossa/api/task_run.py Outdated Show resolved Hide resolved
pybossa/auth/taskrun.py Outdated Show resolved Hide resolved
@XiChenn
Copy link

XiChenn commented Jan 24, 2023

Pull Request Test Coverage Report for Build 3997283415

  • 12 of 15 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pybossa/api/task.py 2 3 66.67%
pybossa/api/task_run.py 3 4 75.0%
pybossa/auth/taskrun.py 7 8 87.5%
Totals Coverage Status
Change from base Build 3960710143: -0.01%
Covered Lines: 16467
Relevant Lines: 17526

💛 - Coveralls

Coverage has been decreased. Could you make it coverved?

@dchhabda
Copy link
Author

Pull Request Test Coverage Report for Build 3997283415

  • 12 of 15 (80.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pybossa/api/task.py 2 3 66.67%
pybossa/api/task_run.py 3 4 75.0%
pybossa/auth/taskrun.py 7 8 87.5%
Totals Coverage Status
Change from base Build 3960710143: -0.01%
Covered Lines: 16467
Relevant Lines: 17526

💛 - Coveralls

Coverage has been decreased. Could you make it coverved?

it should be good now.

XiChenn
XiChenn approved these changes Jan 25, 2023
View reviewed changes
Copy link

@XiChenn XiChenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you.

@dchhabda dchhabda merged commit 4f6d416 into main Jan 25, 2023
@XiChenn XiChenn deleted the edit-taskrun branch February 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiChenn XiChenn XiChenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dchhabda @coveralls @XiChenn