Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-5653 Bug With Showing Completed Answers #810

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

XiChenn
Copy link

@XiChenn XiChenn commented Feb 7, 2023

Issue number of the reported bug or feature request: RDISCROWD-5653

Describe your changes

  • Using document.getElementById("annex-viewer") or document.getElementById("shell-container") to identify Annex shell instead of shell.setAttribute("hash", "anything"); because Annex doesn't always have to set hash attribute.
  • For "table-element", if the existing data contains a list of javascript object and task.info.some_attribute in the object, the code will parse the ``task.info.some_attribute``` and get the corresponding data for it.
  • Exception handling added.

Testing performed
Tested locally.

Additional context
None

@XiChenn XiChenn requested a review from n00rsy February 7, 2023 22:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4118751335

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 93.99%

Totals Coverage Status
Change from base Build 4076129468: 0.005%
Covered Lines: 16516
Relevant Lines: 17572

💛 - Coveralls

Copy link

@n00rsy n00rsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@XiChenn XiChenn merged commit b917bc4 into main Feb 8, 2023
@XiChenn XiChenn deleted the RDISCROWD-5653-bugfix-showing-completed-answers branch February 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants