Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-5742 sorting saved filters list #843

Merged
merged 4 commits into from
May 10, 2023

Conversation

n00rsy
Copy link

@n00rsy n00rsy commented May 4, 2023

Issue number of the reported bug or feature request: RDISCROWD-5742

Describe your changes
All /taskbrowse_bookmarks API calls return an updated list of bookmarks.

  • POST adds a bookmark to the list and the API response is an updated list
  • DELETE removes a bookmark from the list and the API returns an updated list
  • GET gets the current list of bookmarks

This PR adds 2 new optional url query parms, order_by and desc to specify the order of the resultant lists. Options are

  • order_by = name, updated, or created
  • desc = true/ false

The default sort is by alphabetically by bookmark name.

Example query:
http://localhost:5000/account/user/taskbrowse_bookmarks/testproject2?order_by=created&desc=true

Example response:
unchanged from before, but ordered by created date and descending

Testing performed
Tested locally.

Additional context
https://jira.prod.bloomberg.com/browse/RDISCROWD-5743

@coveralls
Copy link

coveralls commented May 4, 2023

Pull Request Test Coverage Report for Build 4938162375

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 94.124%

Totals Coverage Status
Change from base Build 4812666301: 0.002%
Covered Lines: 16915
Relevant Lines: 17971

💛 - Coveralls

pybossa/view/account.py Outdated Show resolved Hide resolved
pybossa/view/account.py Show resolved Hide resolved
pybossa/view/account.py Outdated Show resolved Hide resolved
Copy link

@XiChenn XiChenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you.

remove none check on delete

CR changes
@XiChenn
Copy link

XiChenn commented May 10, 2023

LGTM. Can be merged upon unit tests passed.

@n00rsy n00rsy merged commit 5e5d2bf into main May 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants