-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDISCROWD-6259: BCOS v2 support under fileproxy #879
Conversation
dchhabda
commented
Oct 19, 2023
•
edited
Loading
edited
- add boto3 support
- profiling fileproxy code
- add ability to import csv under bcos v2 buckets via /fileproxy
- add ability for task presenter to load contents from file under bcos v2
Pull Request Test Coverage Report for Build 6643652966
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep explained that in this PR he is adding support for boto3 so that he can test it before making further changes. He is also adding profiling to support additional transparency as he goes.
@ciaracian , the PR has been modified for importing task supporting v2; updated description with details. I'm working on adding more tests. However, code can be reviewed. Please review when you get chance. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, to the best of my knowledge. Thanks Deep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thanks Deep!