Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDISCROWD-6259: BCOS v2 support under fileproxy #879

Merged
merged 7 commits into from
Oct 25, 2023
Merged

RDISCROWD-6259: BCOS v2 support under fileproxy #879

merged 7 commits into from
Oct 25, 2023

Conversation

dchhabda
Copy link

@dchhabda dchhabda commented Oct 19, 2023

  • add boto3 support
  • profiling fileproxy code
  • add ability to import csv under bcos v2 buckets via /fileproxy
  • add ability for task presenter to load contents from file under bcos v2

@coveralls
Copy link

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6643652966

  • 132 of 184 (71.74%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.914%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pybossa/cloud_store_api/connection.py 36 38 94.74%
pybossa/cloud_store_api/base_conn.py 85 135 62.96%
Totals Coverage Status
Change from base Build 6510840306: -0.2%
Covered Lines: 17099
Relevant Lines: 18207

💛 - Coveralls

ciaracian
ciaracian previously approved these changes Oct 19, 2023
Copy link

@ciaracian ciaracian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep explained that in this PR he is adding support for boto3 so that he can test it before making further changes. He is also adding profiling to support additional transparency as he goes.

@dchhabda dchhabda changed the title boto3. profiling RDISCROWD-6259: BCOS v2 support under fileproxy Oct 23, 2023
@dchhabda
Copy link
Author

dchhabda commented Oct 24, 2023

Deep explained that in this PR he is adding support for boto3 so that he can test it before making further changes. He is also adding profiling to support additional transparency as he goes.

@ciaracian , the PR has been modified for importing task supporting v2; updated description with details. I'm working on adding more tests. However, code can be reviewed. Please review when you get chance. Thanks!

ciaracian
ciaracian previously approved these changes Oct 24, 2023
Copy link

@ciaracian ciaracian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, to the best of my knowledge. Thanks Deep!

Copy link

@ciaracian ciaracian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks Deep!

@dchhabda dchhabda merged commit c831c29 into main Oct 25, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants