RDISCROWD-6956 add ssl cert path to proxy service request #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbecker42
previously approved these changes
May 28, 2024
dchhabda
reviewed
May 28, 2024
Pull Request Test Coverage Report for Build 9287214280Details
💛 - Coveralls |
dchhabda
reviewed
May 29, 2024
pybossa/api/__init__.py
Outdated
Comment on lines
710
to
711
| ssl_cert = current_app.config.get('SSL_CERT_PATH') | ||
| ret = requests.post(url, headers=headers, json=payload['data'], verify=ssl_cert if ssl_cert else True) |
There was a problem hiding this comment.
This could be
ssl_cert = current_app.config.get('SSL_CERT_PATH', False)
ret = requests.post(url, headers=headers, json=payload['data'], verify=ssl_cert)There was a problem hiding this comment.
@dchhabda verify is True by default so this would change existing behavior for missing certs. I will change the first line to:
ssl_cert = current_app.config.get('SSL_CERT_PATH', True)
There was a problem hiding this comment.
for missing certs path in configs, IMO ssl_cert would be set to False which would superimpose default verify=True behavior. Let's connect offline if needed. Thanks!
dchhabda
approved these changes
May 30, 2024
ciaracian
pushed a commit
that referenced
this pull request
Jul 23, 2024
* RDISCROWD-6956 add ssl cert path to proxy service request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: RDISCROWD-6956
Describe your changes
add ssl cert path to proxy service request