Skip to content

Commit

Permalink
Fix tests in arch Linux
Browse files Browse the repository at this point in the history
In the latest iteration of the arch Linux container, we need to also
deactivate seccomp to be able to run `gcore` and `ptrace` in the
container.

In addition to that, seems that the new libc is too optimized and some
of our tests are too strict over the number of native frames that must
be present in pthread-based threads, so we need to be a bit more
permissive.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
  • Loading branch information
pablogsal committed Jul 4, 2023
1 parent f22c476 commit 000ff46
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,7 @@ jobs:

container:
image: archlinux
options: --cap-add=SYS_PTRACE

options: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined
steps:
- uses: actions/checkout@v3
- uses: actions/download-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_core_analyzer.py
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ def test_thread_registered_with_python_with_other_threads(tmpdir):
assert lines == [13, 10]

native_frames = list(non_python_thread.native_frames)
assert len(native_frames) >= 5
assert len(native_frames) >= 4
symbols = {frame.symbol for frame in native_frames}
assert any(
[
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/test_gather_stacks.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def test_thread_registered_with_python_with_other_threads(tmpdir):
assert lines == [13, 10]

native_frames = list(non_python_thread.native_frames)
assert len(native_frames) >= 5
assert len(native_frames) >= 4
symbols = {frame.symbol for frame in native_frames}
assert any(
[
Expand Down

0 comments on commit 000ff46

Please sign in to comment.