-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle bss sections that span multiple segments #1
Comments
What platform does this happen on? I think I've written most of a fix for it, but I'm not gonna be super confident I've got it right until seeing it work with a core file that actually does have the BSS split into different segments. |
Not sure I recall the distro but may be one of the manylinux images that we use for wheels. Check there because there are plenty of stuff failing there and most of the failures are related to this if I recall correctly |
We were wrong about what was happening here. It wasn't that the BSS was spanning multiple segments, it's that we were incorrectly computing the offset for the BSS section, because we were assuming that the first segment for a module in the core file would be that module's first loadable segment, when in reality core files may elide read-only segments. |
Is possible that the
.bss
section of a core file spans multiple segments. We currently handle this suboptimally as we create a virtual "segment" for the entirebss
section when we pass it to the process manager. The problem with this is that when we need to copy the entire.bss
section at once (or really anything that is not fully contained in a single segment) our memory copy machinery complains because is not prepared to work with a chunk of memory that spans multiple segments.There are two possibilities here:
.bss
section instead of a single one.The text was updated successfully, but these errors were encountered: