Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Skip aarch64 builds except for new releases #115

Merged

Conversation

godlygeek
Copy link
Contributor

These builds are extremely slow due to needing to rely on emulation, and we can't adequately test them due to the emulation not providing all syscalls that we require. There's little point to wasting time building something that we can't test for every push to a PR branch, so we'll defer building these until the time a release is cut.

@godlygeek godlygeek self-assigned this Jul 10, 2023
@godlygeek godlygeek force-pushed the build_aarch64_wheels_only_for_releases branch 4 times, most recently from 6c4ce08 to 6b3c44c Compare July 10, 2023 23:32
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7f4d56b) 90.34% compared to head (6b3c44c) 90.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          47       47           
  Lines        5480     5480           
  Branches      863      863           
=======================================
  Hits         4951     4951           
  Misses        529      529           
Flag Coverage Δ
cpp 75.18% <ø> (ø)
python_and_cython 99.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@godlygeek godlygeek force-pushed the build_aarch64_wheels_only_for_releases branch 6 times, most recently from 0856d97 to 1ff901b Compare July 10, 2023 23:49
These builds are extremely slow due to needing to rely on emulation, and
we can't adequately test them due to the emulation not providing all
syscalls that we require. There's little point to wasting time building
something that we can't test for every push to a PR branch, so we'll
defer building these until the time a release is cut.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek godlygeek force-pushed the build_aarch64_wheels_only_for_releases branch from 1ff901b to 97abf32 Compare July 10, 2023 23:51
@godlygeek godlygeek marked this pull request as ready for review July 11, 2023 00:19
@pablogsal pablogsal enabled auto-merge (rebase) July 11, 2023 14:13
@pablogsal pablogsal merged commit c146d11 into bloomberg:main Jul 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants