Add pkgconfig support in the setup.py #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
previously requested changes
Jul 16, 2023
|
Ah, the Coverage workflow failed because pystack/.github/workflows/coverage.yml Line 50 in 8473602 pkgconfig.
|
Added support for pkgconfig Signed-off-by: Apurva Khatri <apurvakhatri2011@gmail.com>
Installing pkgconfig Signed-off-by: Apurva Khatri <apurvakhatri2011@gmail.com>
Instructions for pkg-config added Signed-off-by: Apurva Khatri <apurvakhatri2011@gmail.com>
pablogsal
force-pushed
the
pkgconfig
branch
2 times, most recently
from
3a5806d
to
0e33282
Compare
|
I have rebased and manually applied @godlygeek suggestions to move this forward. Thanks a lot for the contribution @apurvakhatri 🚀 |
pablogsal
approved these changes
Aug 1, 2023
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #54
Describe your changes
I have added support for pkgconfig in setup.py. Python's pkgconfig depends on system package pkg-config. The instructions on how to install pkg-config has also been added to README.md. The changes uses pkgconfig to look for clfags & ldflags to use for libelf and libdw. If pkgconfig is unable to determine the flags then the default pre-configured behavior is used.
Testing performed
Testing has been performed on Ubuntu 22.04.2 LTS
Additional context
Closes: #54