Add gzip support #171
Merged
Add gzip support #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
pablogsal
reviewed
May 7, 2024
|
Thanks a lot for the PR! I will try to review it this week :) |
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
|
Great job! We are almost there You need a news entry - an |
|
Is this the correct format for the news entry? |
Signed-off-by: Robert Queenin <2177841+ecalifornica@users.noreply.github.com>
|
Thanks for running the checks yesterday @godlygeek. I've picked up your fix for the Alpine test failure and removed the code that was causing the Python3.7 failure. Hopefully those changes should cause this PR to go green. |
pablogsal
approved these changes
Jun 4, 2024
|
Sorry this took too long to merge @ecalifornica and congrats on the merge! Thanks a lot for being so patient with this and for following our (slow) feedback! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #168 *
Describe your changes
Add check for core dump file ending in
.gz. If so, decompress to temporary file and run analyzer on temporary file.Testing performed
Added a unit test following the pattern of current tests. It mocks calls to
gzipandtempfile, asserts that the analyzer was called with the correct path. It does not test for any failure modes, and really only tests the mocks. Happy to add more tests if requested.Additional context