Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit setup #64

Merged
merged 2 commits into from Apr 24, 2023
Merged

Add pre-commit setup #64

merged 2 commits into from Apr 24, 2023

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented Apr 24, 2023 •
edited

Issue number of the reported bug or feature request: closes #63

Describe your changes

  • Added pre-commit to extra requirements
  • Created the .pre-commit-config.yaml file
  • Update contributing instructions on enabling pre-commit for local development
  • Fixed issues in various files.

Testing performed

  1. Installed pre-commit and set it up. All commits in this PR used the checks.
  2. Ran all hooks against the repository: pre-commit run --files *

Additional context
I also added some pre-commit hooks that I like to work. These are in the top two sections of the YAML file.

@stefmolin stefmolin marked this pull request as ready for review April 24, 2023 15:59
@olgarithms olgarithms mentioned this pull request Apr 24, 2023
Merged
godlygeek
godlygeek approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefmolin @godlygeek
Integrate with pre-commit for linting
5031ff5 
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
@stefmolin @godlygeek
Apply updated formatting
0798ff4 
Signed-off-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
@godlygeek godlygeek enabled auto-merge (rebase) April 24, 2023 22:09
@godlygeek godlygeek merged commit 71b9746 into bloomberg:main Apr 24, 2023
19 checks passed
@stefmolin stefmolin deleted the add-pre-commit branch April 24, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godlygeek godlygeek godlygeek approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using pre-commit for managing our linting setup
2 participants
@stefmolin @godlygeek