Remove extras-requires
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having these dependencies both in `requirements-*.txt` as well as in `setup.py` allows for inconsistencies, such as the missing `pyinstaller` dependency that really should be in the test dependencies. After discussing this, it seems like it's harder to read the `setup.py` file by Docker and CI in general than the `requirements-*.txt`. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having these dependencies both in
requirements-*.txtas well as insetup.pyallows for inconsistencies, such as the missingpyinstallerdependency that really should be in the test dependencies. After discussing this, it seems like it's harder to read thesetup.pyfile by Docker and CI in general than therequirements-*.txt.Describe your changes
This PR removes all
extras_requiresections fromsetup.py, such that the development dependencies are not part of the package that gets published to PyPI.Testing performed
Reinstalling and running all of the tests and coverage locally with that new setup.
Additional context
PyCon US 2023 ftw.