Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile release command #84

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

jayybhatt
Copy link
Contributor

*Issue number of the reported bug or feature request: #49 *

Describe your changes

  • Check if the RELEASE env var is set before running make release
  • Add towncrier step in CI

Testing performed

  • Added an invalid RST file in the news/
  • Ran towncrier to generate the NEWS.rst
  • Then make docs detects an error

Additional context
Closes #49

@jayybhatt jayybhatt force-pushed the makefile-release-command branch 2 times, most recently from 1768445 to a3a095c Compare April 25, 2023 22:13
Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>
Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>
Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>
pablogsal
pablogsal previously approved these changes Apr 26, 2023
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fantastic job!

@pablogsal pablogsal merged commit 869e657 into bloomberg:main Apr 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure news fragments are valid reStructuredText
2 participants