Makefile Docker Targets #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making this now for sanity purposes as a draft PR, still need to go back and sign commits / squash |
pablogsal
force-pushed
the
docker-83
branch
6 times, most recently
from
53a6d38
to
2c831fa
Compare
Extracting out variables, formatting Reformatting command Improved command that opens the existing container if it exists Including Docker RM command Removed PDB reference from git Added Pytest-Fork, Cleanup Remove tox.ini and add a Github workflow to run pycoverage (bloomberg#80) We don't use tox anymore so we can just use regular GH actions and regular pytest invocations to run all required CI targets. Run Sphinx in nitpicky mode Signed-off-by: Kulendra Kumar Kaushal <kulendra007@gmail.com> Add a check in the Makefile for RELEASE Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com> Added towncrier step to the CI Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com> Add --keep flag on towncrier Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com> Build elfutils in Dockerfile Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal
approved these changes
May 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #83
Describe your changes
Added Makefile Targets for Docker Development Commands
Testing performed
Executing
make checkinside of the docker containerAdditional context
None