Clean up references to unused tech #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few things that we are no longer using, such as `prettier` or `bbpy`, that we don't need and should probably have been removed in previous PRs. I found those with running `git grep -i bb` and `git grep -i prett` to ensure I'm not missing any. Some of the corefiles still mention `/opt/bb/*` folders in their compilation flags, but I don't think it matters. Signed-off-by: Gus Monod <gmonod1@bloomberg.net>
pablogsal
approved these changes
May 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removed references to
bbpy,prettier, or/opt/bb/*paths.Testing performed
I found those with running
git grep -i bbandgit grep -i prettto ensure I'm not missing any, and no text files match.Additional context
Some of the corefiles still mention
/opt/bb/*folders in their compilation flags, but I don't think it matters.