Use PEP-621 for project metadata, extras for deps and VCS for version #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
changed the title
bumpversion is no longer used. Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
pablogsal
reviewed
May 11, 2022
|
Hummm, seems that either we were not checking correctly coverage or for some reason the coverage went down :( |
pablogsal
reviewed
May 11, 2022
|
We were not checking it correctly, looked at coverage HTML report and looked legit. |
Then decrease the percentage so the check passes, please |
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
pablogsal
approved these changes
May 11, 2022
pablogsal
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernát Gábor bgabor8@bloomberg.net