Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements #13

Merged
merged 7 commits into from
May 13, 2022
Merged

General improvements #13

merged 7 commits into from
May 13, 2022

Conversation

gaborbernat
Copy link
Contributor

  • Use pytest imports from root
  • Use f-string instead of percentage format
  • Use modern typing annoations
  • Make the plugin code a bit more compact
  • Use modern API from pytest
  • Fix mypy

gaborbernat and others added 6 commits May 11, 2022 14:20
@gaborbernat
Use pytest imports from root
31db079 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Use f-string instead of percentage format
22de8fa 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Use modern typing annoations
4110fcb 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Make the plugin code a bit more compact
9996fcd 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat
Use modern API from pytest
0b27c3d 
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat
Fix mypy
ce5ad6e 
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@gaborbernat gaborbernat changed the title path General improvements May 12, 2022
@gaborbernat
Bump coverage requirement
4fea669 
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
@pablogsal pablogsal merged commit b53e804 into bloomberg:main May 13, 2022
@pablogsal
Copy link
Member

Thanks a lot @gaborbernat !

@gaborbernat gaborbernat deleted the path branch May 13, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaborbernat @pablogsal