Make the plugin compatible with pytest-xdist #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
xdist
branch
5 times, most recently
from
0b6dd25
to
b4e8b6c
Compare
gaborbernat
reviewed
Nov 15, 2022
godlygeek
reviewed
Nov 15, 2022
|
pytest-xdist allows distributing tests across multiple hosts, as well. Should we detect when it was run in that mode and warn or fail? |
Hummm. I would need to investigate. Do you mind if we do this in a another PR? |
The pytest-xdist plugin spawns worker processes that run the tests while the main process reports the results. As every process has its own copy of all the plugins, this means that when the main process reports the final summary, it doesn't have access to the results stored by every individual test so the plugin is unable to print the summary. To make ourselves compatible with pytest-xdist, we make the main process and the workers use a common path to store the metadata and result files (this is communicated from the main process to the workers by an environment variable). Then, at report time, if the main process doesn't have any result data, it will fetch it from this directory instead. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
I have addressed all comments, please take another look |
gaborbernat
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pytest-xdist plugin spawns worker processes that run the tests while
the main process reports the results. As every process has its own copy
of all the plugins, this means that when the main process reports the
final summary, it doesn't have access to the results stored by every
individual test so the plugin is unable to print the summary.
To make ourselves compatible with pytest-xdist, we make the main process
and the workers use a common path to store the metadata and result files
(this is communicated from the main process to the workers by an
environment variable). Then, at report time, if the main process doesn't
have any result data, it will fetch it from this directory instead.
Closes: #2